On Tue, 11 Mar 2025 14:48:12 GMT, GennadiyKrivoshein <d...@openjdk.org> wrote:
>> Fix for https://bugs.openjdk.org/browse/JDK-8349350. It's impossible to use >> more that one print option. >> >> **Reason of the bug**: >> execCmd array uses one index per print flag, but 'OPTIONS' flag can use two >> indexes for the options. >> >> **Fix description**: >> make the size of the execCmd array dependent on the number of options. >> >> **Test**: >> new test PrintExecCmdOptionTest.java created to check execution with >> multiple options. (run on MacOS, Windows and linux x86_64) > > GennadiyKrivoshein has updated the pull request incrementally with one > additional commit since the last revision: > > restore original printstream Marked as reviewed by prr (Reviewer). test/jdk/javax/print/UnixPrintJobOptionsTest.java line 54: > 52: * @run main/manual/othervm -Dsun.print.ippdebug=true > UnixPrintJobOptionsTest > 53: */ > 54: You also made the test manual, yet it has no user interaction. It ought to be enough that you tagged it as a printer test. I'll approve, but maybe it could be reverted to automated ?? I notice that it actually prints - although it is a blank page. I suppose it has to, in order to get the command line to be used. ------------- PR Review: https://git.openjdk.org/jdk/pull/23457#pullrequestreview-2676283937 PR Review Comment: https://git.openjdk.org/jdk/pull/23457#discussion_r1990223608
