On Tue, 11 Mar 2025 21:11:16 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> Harshitha Onkar has updated the pull request incrementally with one >> additional commit since the last revision: >> >> modifier order changed, added comment to BuiltInProfile > > src/java.desktop/share/classes/java/awt/color/ICC_Profile.java line 126: > >> 124: /* >> 125: * Deferral is only used for standard profiles. Enabling the >> appropriate >> 126: * access privileges is handled at a lower level. > > I wonder if “Enabling the appropriate access privileges is handled at a lower > level” is still relevant after `SecurityManager` was removed. I missed reading it. Yes, you are right. I think it can be removed. Also do we keep - `Deferral is only used for standard profiles` ? It may be redundant after adding the note? * ProfileDeferralInfo is used for only built-in profile creation and * all built-in profiles should be constructed using it. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/23606#discussion_r1990138600