On Tue, 11 Mar 2025 21:16:00 GMT, Harshitha Onkar <hon...@openjdk.org> wrote:

>> src/java.desktop/share/classes/java/awt/color/ICC_Profile.java line 126:
>> 
>>> 124:         /*
>>> 125:          * Deferral is only used for standard profiles. Enabling the 
>>> appropriate
>>> 126:          * access privileges is handled at a lower level.
>> 
>> I wonder if “Enabling the appropriate access privileges is handled at a 
>> lower level” is still relevant after `SecurityManager` was removed.
>
> I missed reading it. Yes, you are right. I think it can be removed.
> 
> Also do we keep - `Deferral is only used for standard profiles` ? 
> It may be redundant after adding the note?
> 
> 
>          * ProfileDeferralInfo is used for only built-in profile creation and
>          * all built-in profiles should be constructed using it.

The first sentence can also be removed. The newly added sentence repeats the 
first one.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23606#discussion_r1990141355

Reply via email to