On Fri, 11 Apr 2025 17:14:06 GMT, Harshitha Onkar <hon...@openjdk.org> wrote:
>> Jayathirth D V has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Update after review > > test/jdk/javax/swing/JList/bug4193267.java line 63: > >> 61: .instructions(INSTRUCTIONS) >> 62: .columns(35) >> 63: .testUI(initialize()) > > PassFailJFrame's ` .positionTestUI(WindowLayouts::rightOneRow)` can be used > to position multiple windows side by side. Updated. > test/jdk/javax/swing/JList/bug4618767.java line 51: > >> 49: private static JList list; >> 50: private static boolean menuSelected; >> 51: private static boolean failed; > > Since it is accessed on two different threads. > > Suggestion: > > private static volatile boolean failed; Updated. > test/jdk/javax/swing/JList/bug4618767.java line 107: > >> 105: } >> 106: Robot robot = new Robot(); >> 107: robot.setAutoDelay(500); > > Can we reduce autoDelay to a smaller number? I was seeing some issues related to autoDelay in our CI, so used 500ms. I think it is resolved and we can keep it less. Updated to 200ms. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24588#discussion_r2041456914 PR Review Comment: https://git.openjdk.org/jdk/pull/24588#discussion_r2041458969 PR Review Comment: https://git.openjdk.org/jdk/pull/24588#discussion_r2041462132
