On Fri, 11 Apr 2025 20:19:30 GMT, Andrey Turbanov <aturba...@openjdk.org> wrote:

>> Jayathirth D V has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Update after review
>
> test/jdk/javax/swing/JList/bug4193267.java line 84:
> 
>> 82:         jsp = new JScrollPane(lst);
>> 83:         fr[0].add(jsp);
>> 84:         fr[0].setSize(400,200);
> 
> Suggestion:
> 
>         fr[0].setSize(400, 200);

Updated.

> test/jdk/javax/swing/JList/bug4193267.java line 87:
> 
>> 85: 
>> 86:         JPanel pL = new JPanel();
>> 87:         pL.setLayout(new GridLayout(2,1));
> 
> Suggestion:
> 
>         pL.setLayout(new GridLayout(2, 1));

Updated.

> test/jdk/javax/swing/JList/bug4193267.java line 92:
> 
>> 90: 
>> 91:         JPanel p = new JPanel();
>> 92:         p.setLayout(new GridLayout(2,1));
> 
> Suggestion:
> 
>         p.setLayout(new GridLayout(2, 1));

Updated.

> test/jdk/javax/swing/JList/bug4193267.java line 103:
> 
>> 101: 
>> 102:         fr[1] = new JFrame("Index");
>> 103:         fr[1].setSize(200,200);
> 
> Suggestion:
> 
>         fr[1].setSize(200, 200);

Updated.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24588#discussion_r2041457586
PR Review Comment: https://git.openjdk.org/jdk/pull/24588#discussion_r2041457722
PR Review Comment: https://git.openjdk.org/jdk/pull/24588#discussion_r2041457852
PR Review Comment: https://git.openjdk.org/jdk/pull/24588#discussion_r2041457978

Reply via email to