> The javadoc for PassFailJFrame.forcePass suggests an anti-pattern of forcibly 
> passing the test if a resource is unavailable.
> 
> If a resource is unavailable or a feature isn't supported, the test should 
> throw jtreg.SkippedException.
> 
> PassFailJFrame.forcePass should be used in semi-automatic tests when the test 
> determines that all the conditions for passing the test are met.
> Please refer: JDK-8355366 and https://github.com/openjdk/jdk/pull/24820
> 
> Testing
> This is a javadoc change, so not testing required.

Manukumar V S has updated the pull request incrementally with one additional 
commit since the last revision:

  Review comments fixed : Formatting changes, added reference to a real test

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/24837/files
  - new: https://git.openjdk.org/jdk/pull/24837/files/99b9cfb2..97b8b5a5

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=24837&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=24837&range=00-01

  Stats: 12 lines in 1 file changed: 1 ins; 6 del; 5 mod
  Patch: https://git.openjdk.org/jdk/pull/24837.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/24837/head:pull/24837

PR: https://git.openjdk.org/jdk/pull/24837

Reply via email to