On Mon, 28 Apr 2025 20:58:41 GMT, Harshitha Onkar <hon...@openjdk.org> wrote:

>> Manukumar V S has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Updated line number in code link
>
> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 1306:
> 
>> 1304:      * <p>A sample usage can be found in
>> 1305:      * <a 
>> href="https://github.com/openjdk/jdk/blob/7283c8b/test/jdk/java/awt/FileDialog/SaveFileNameOverrideTest.java#L84";>{@code
>> 1306:      * SaveFileNameOverrideTest.java}</a>
> 
> Javadoc update LGTM. Maybe the doc for forceFail() can be updated similarly?
> @aivanov-jdk What do you suggest?
> 
> It can be done as a part of this PR change or a separate PR. Since it is a 
> similar doc change, I think it can be done as part of this PR by the changing 
> the JBS title appropriately  - _Update javadocs for PassFailJFrame's 
> forcePass() & forceFail() methods_

@honkar-jdk @aivanov-jdk Can I do it as part of 
[JDK-8355515](https://bugs.openjdk.org/browse/JDK-8355515)?.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24837#discussion_r2066143887

Reply via email to