On Fri, 11 Apr 2025 05:34:15 GMT, Manukumar V S <m...@openjdk.org> wrote:
>> java/awt/ScrollPane/bug8077409Test.java is unstable and fails intermittently
>> in CI, especially in MacOS machines.
>> Also the frame created in this test is not disposed which may interfere with
>> other tests.
>>
>> Fix:
>> Some stabilisations added and the frame is disposed properly.
>>
>> Testing:
>> Tested 100 times per
>> platform(macosx-x64,macosx-aarch64,windows-x64,linux-x64) and got all PASS.
>
> Manukumar V S has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review comments fixed : Code reformatting, changed the indentation to the
> standard four-space indentation
test/jdk/java/awt/ScrollPane/bug8077409Test.java line 69:
> 67: try {
> 68: obj.setLocationRelativeTo(null);
> 69: Toolkit.getDefaultToolkit().addAWTEventListener(e -> {
This test is not manual and does not use a robot to click. How can this
listener be called?
test/jdk/java/awt/ScrollPane/bug8077409Test.java line 100:
> 98:
> 99: int y = obj.pane.getComponent(0).getLocation().y;
> 100: robot.waitForIdle();
Why do you need to wait in this line?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24292#discussion_r2061129952
PR Review Comment: https://git.openjdk.org/jdk/pull/24292#discussion_r2061129478
