On Mon, 28 Apr 2025 09:32:26 GMT, Manukumar V S <m...@openjdk.org> wrote:
>> java/awt/ScrollPane/bug8077409Test.java is unstable and fails intermittently
>> in CI, especially in MacOS machines.
>> Also the frame created in this test is not disposed which may interfere with
>> other tests.
>>
>> Fix:
>> Some stabilisations added and the frame is disposed properly.
>>
>> Testing:
>> Tested 100 times per
>> platform(macosx-x64,macosx-aarch64,windows-x64,linux-x64) and got all PASS.
>> I have also tested this on Windows-x64 with JDK 8u60b04 and JDK 8u60b20 as
>> the original issue related to this test(JDK-8077409) was fixed in JDK
>> 8u60b20.
>> With JDK 8u60b04:
>> Exception in thread "main" java.lang.RuntimeException: Wrong position of
>> component in ScrollPane
>> at bug8077409Test.main(bug8077409Test.java:142)
>>
>> With JDK 8u60b20:
>> Passed.....
>
> Manukumar V S has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Review comments fixed : Removed unwanted code and updated copyright year
test/jdk/java/awt/ScrollPane/bug8077409Test.java line 32:
> 30: */
> 31:
> 32:
Extra blank line can be removed.
test/jdk/java/awt/ScrollPane/bug8077409Test.java line 58:
> 56: add(pane, BorderLayout.CENTER);
> 57: setSize(320, 480);
> 58:
For consistency, blank line can be removed.
test/jdk/java/awt/ScrollPane/bug8077409Test.java line 75:
> 73: throw new RuntimeException("Wrong position of component
> in ScrollPane");
> 74: } else {
> 75: System.out.println("Passed.....");
Redundant print statement.
test/jdk/java/awt/ScrollPane/bug8077409Test.java line 85:
> 83: protected void processKeyEvent(KeyEvent e) {
> 84: super.processKeyEvent(e);
> 85:
For consistency, blank line can be removed.
test/jdk/java/awt/ScrollPane/bug8077409Test.java line 89:
> 87:
> 88: class MyCanvas extends Canvas {
> 89: public Dimension getPreferredSize() {
You can add @Override for overridden method
test/jdk/java/awt/ScrollPane/bug8077409Test.java line 93:
> 91: }
> 92:
> 93: public void paint(Graphics g) {
You can add `@Override` for overridden method
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24292#discussion_r2071382835
PR Review Comment: https://git.openjdk.org/jdk/pull/24292#discussion_r2071386731
PR Review Comment: https://git.openjdk.org/jdk/pull/24292#discussion_r2071384232
PR Review Comment: https://git.openjdk.org/jdk/pull/24292#discussion_r2071386531
PR Review Comment: https://git.openjdk.org/jdk/pull/24292#discussion_r2071385141
PR Review Comment: https://git.openjdk.org/jdk/pull/24292#discussion_r2071384845
