On Fri, 25 Apr 2025 19:49:02 GMT, Alisen Chung <ach...@openjdk.org> wrote:
> Test was failing on Ubuntu, looks to be a synchronous error in the test so I > rewrote it to improve stability. test/jdk/java/awt/event/KeyEvent/ExtendedKeyCode/ExtendedKeyCodeTest.java line 48: > 46: > 47: try { > 48: SwingUtilities.invokeAndWait(() -> createTestGUI()); It should be EventQueue.invokeAndWait. and it actually is not needed since only awt components are used. There are no obvious issues related to stability, proper use of synchronization+waitForIdle+setAutoDelay. test/jdk/java/awt/event/KeyEvent/ExtendedKeyCode/ExtendedKeyCodeTest.java line 72: > 70: robot.waitForIdle(); > 71: > 72: if (eventsCount != 2 || !setExtendedKeyCode) { I suggest to add logging here and rerun it many-many times to reproduce the bug to find out if the problem is in the wrong number of events or in the wrong extended state. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24885#discussion_r2061130401 PR Review Comment: https://git.openjdk.org/jdk/pull/24885#discussion_r2061133409