On Fri, 25 Apr 2025 13:30:02 GMT, Nikita Gubarkov <ngubar...@openjdk.org> wrote:
> `SurfaceManagerFactory` just checks a given `GraphicsConfiguration` against > multiple types via `instanceof`, it has 3 platform-specific implementations, > which rely on an ugly injection process. > > There is no reason to have this class at all, we could just let > `GraphicsConfiguration` create a compatible `SurfaceManager` instead. > > This would reduce coupling without having to collect all surface manager > types in a single place (without real need to do so). > And this would also remove dependency on the class initialization sequence by > getting rid of the injection process. This pull request has now been integrated. Changeset: 40e7986c Author: Nikita Gubarkov <ngubar...@openjdk.org> Committer: Alexey Ushakov <a...@openjdk.org> URL: https://git.openjdk.org/jdk/commit/40e7986c412797323f721212d5f375ffe15accb3 Stats: 411 lines in 20 files changed: 79 ins; 308 del; 24 mod 8355611: Get rid of SurfaceManagerFactory Reviewed-by: serb, prr ------------- PR: https://git.openjdk.org/jdk/pull/24875
