On Tue, 29 Apr 2025 11:45:17 GMT, Manukumar V S <m...@openjdk.org> wrote:
>> test/jdk/java/awt/regtesthelpers/PassFailJFrame.java line 1306: >> >>> 1304: * <p>A sample usage can be found in >>> 1305: * <a >>> href="https://github.com/openjdk/jdk/blob/7283c8b/test/jdk/java/awt/FileDialog/SaveFileNameOverrideTest.java#L84";>{@code >>> 1306: * SaveFileNameOverrideTest.java}</a> >> >> Javadoc update LGTM. Maybe the doc for forceFail() can be updated similarly? >> @aivanov-jdk What do you suggest? >> >> It can be done as a part of this PR change or a separate PR. Since it is a >> similar doc change, I think it can be done as part of this PR by the >> changing the JBS title appropriately - _Update javadocs for >> PassFailJFrame's forcePass() & forceFail() methods_ > > @honkar-jdk @aivanov-jdk Can I do it as part of > [JDK-8355515](https://bugs.openjdk.org/browse/JDK-8355515)?. Absolutely! I don't want to include any changes for `forceFail` here because they're unrelated to the problem we're addressing. [The description](https://bugs.openjdk.org/browse/JDK-8355515#description) of JDK-8355515 explicitly mentions the intent: > The description of `forceFail()` should be expanded, too. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24837#discussion_r2066231116
