On Tue, 6 May 2025 20:20:04 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> Pabulaner IV has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - 8332947: [macos] java.awt.desktop.OpenURIHandler is not receiving events >> - 8332947: [macos] java.awt.desktop.OpenURIHandler is not receiving events >> - 8332947: [macos] java.awt.desktop.OpenURIHandler is not receiving events > > src/java.desktop/macosx/native/libawt_lwawt/awt/ApplicationDelegate.m line > 302: > >> 300: >> 301: NSString *url = [[openURLEvent >> paramDescriptorForKeyword:keyDirectObject] stringValue]; >> 302: [self _openURL:url]; > > `_openURL` is a class method. Using `self` is incorrect and causes a failure > in the normal (non-embedded) case. > > Suggestion: > > [ApplicationDelegate _openURL:url]; Thanks for the feedback, I am new to Objective C, so it the feedback is much appreciated! ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/24379#discussion_r2078057470
