On Tue, 13 May 2025 05:19:09 GMT, Renjith Kannath Pariyangad
<[email protected]> wrote:
>> Hi Reviewers,
>>
>> I have updated the test and made it semi-automatic (need to click "Print") .
>> Test will initiate a print and result will be generated automatic.
>>
>> Please review and let me know your suggestions.
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with
> two additional commits since the last revision:
>
> - Removed comment
> - Updated based on suggesion
Marked as reviewed by aivanov (Reviewer).
test/jdk/java/awt/print/PrinterJob/PrintNullString.java line 61:
> 59: public static void main(String[] args) throws Exception {
> 60: if (PrinterJob.lookupPrintServices().length == 0) {
> 61: throw new RuntimeException("Printer not configured or
> available.");
I'd leave the `main` method at the top of the file — it describes what the test
does.
-------------
PR Review: https://git.openjdk.org/jdk/pull/24501#pullrequestreview-2837416278
PR Review Comment: https://git.openjdk.org/jdk/pull/24501#discussion_r2087210314
