On Wed, 14 May 2025 04:07:08 GMT, Renjith Kannath Pariyangad
<rkannathp...@openjdk.org> wrote:
>> Hi Reviewers,
>>
>> I have updated the test and made it semi-automatic (need to click "Print") .
>> Test will initiate a print and result will be generated automatic.
>>
>> Please review and let me know your suggestions.
>
> Renjith Kannath Pariyangad has updated the pull request incrementally with
> one additional commit since the last revision:
>
> Moved main fuction to top
Looks good to me except for a minor nit.
test/jdk/java/awt/print/PrinterJob/PrintNullString.java line 56:
> 54: throw new RuntimeException("Printer not configured or
> available.");
> 55: }
> 56: new PrintNullString();
Suggestion:
new PrintNullString();
Leave a blank line between the skipped condition and the real test code.
-------------
Marked as reviewed by aivanov (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24501#pullrequestreview-2860700039
PR Review Comment: https://git.openjdk.org/jdk/pull/24501#discussion_r2102225612
