On Fri, 9 May 2025 20:54:46 GMT, Phil Race <p...@openjdk.org> wrote:
>> A simple API to replace java.applet.AudioClip
>>
>> CSR is now created : https://bugs.openjdk.org/browse/JDK-8356200
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8356049
test/jdk/javax/sound/SoundClip/SoundClipTest.java line 34:
> 32: * @key sound headful
> 33: * @summary basic testing of javax.sound.SoundClip
> 34: * @run main/othervm SoundClipTest javasound.wav
What about a non-existent or broken file? Should we check for an IOException in
that case?
test/jdk/javax/sound/SoundClip/SoundClipTest.java line 41:
> 39: public static void main(String[] args) throws Exception {
> 40:
> 41: if (!isSoundcardInstalled()) {
Why we cannot check that the playing sound is a no-op in this case, as
specified?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24991#discussion_r2087486464
PR Review Comment: https://git.openjdk.org/jdk/pull/24991#discussion_r2087484987
