On Fri, 9 May 2025 20:54:46 GMT, Phil Race <[email protected]> wrote:
>> A simple API to replace java.applet.AudioClip
>>
>> CSR is now created : https://bugs.openjdk.org/browse/JDK-8356200
>
> Phil Race has updated the pull request incrementally with one additional
> commit since the last revision:
>
> 8356049
src/java.desktop/share/classes/javax/sound/SoundClip.java line 35:
> 33: /**
> 34: * The {@code SoundClip} class is a simple abstraction for playing a
> sound clip.
> 35: * It will play any format that is recognized by the {@code javax.sound}
> API,
I think we should mention in the doc that this is applicable for small audio
files since we will load all data into the memory.
src/java.desktop/share/classes/javax/sound/SoundClip.java line 45:
> 43: * @since 25
> 44: */
> 45: public final class SoundClip {
What about considering a different name, such as AudioClip with a static method
like AudioClip.create(...)? or maybe Audio....Player?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24991#discussion_r2087496834
PR Review Comment: https://git.openjdk.org/jdk/pull/24991#discussion_r2087496010
