On Thu, 15 May 2025 16:20:57 GMT, Harshitha Onkar <[email protected]> wrote:
>> Pabulaner IV has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8332947: [macos] java.awt.desktop.OpenURIHandler is not receiving events
>
> src/java.desktop/macosx/native/libawt_lwawt/awt/ApplicationDelegate.m line
> 494:
>
>> 492: }
>> 493:
>> 494: + (void)_embeddedEvent:(NSNotification *)notification {
>
> @kevinrushforth @prrace
>
> Is '_embeddedEvent' too generic, does it need to be changed to something more
> inline with OpenURI e.g '_openURIEvent' ?
As I noted in an earlier comment, I think the method name, _embeddedEvent , is
fine, since it is private to this file.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24379#discussion_r2091568016
