On Thu, 15 May 2025 16:25:56 GMT, Kevin Rushforth <k...@openjdk.org> wrote:
>> src/java.desktop/macosx/native/libawt_lwawt/awt/ApplicationDelegate.m line
>> 494:
>>
>>> 492: }
>>> 493:
>>> 494: + (void)_embeddedEvent:(NSNotification *)notification {
>>
>> @kevinrushforth @prrace
>>
>> Is '_embeddedEvent' too generic, does it need to be changed to something
>> more inline with OpenURI e.g '_openURIEvent' ?
>
> As I noted in an earlier comment, I think the method name, _embeddedEvent ,
> is fine, since it is private to this file.
Also, while it is only used for openURI today, it could be used to pass
additional messages in the future, so even if he were to change it, it
shouldn't have "openURI" in the name.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24379#discussion_r2091569752
