On Thu, 8 May 2025 21:22:10 GMT, Phil Race <p...@openjdk.org> wrote:
>> src/java.desktop/share/classes/java/awt/Robot.java line 138:
>>
>>> 136: * Default 2 pixel step length for mouse {@code glide}.
>>> 137: */
>>> 138: public static final int DEFAULT_STEP_LENGTH = 2;
>>
>> Do we want to make the `DEFAULT_DELAY` and `DEFAULT_STEP_LENGTH`
>> configurable?
>
> "glide has over-rides step length"
>
> Sorry, that text was not clear. What I mean is that glide(..) accepts delay
> and step parameters, and so at least in that case you can over-ride with your
> preferred values.
>
> Other than that, it isn't configurable in the ExtendedRobot, so the need
> isn't clear.
>
> Even so, we could do this but whether now or later, but in either case,
> we ought to think now as to what it would look like so it can be compatibly
> added.
>
> In ExtendedRobot the equivalent fields are private but here they are public.
> Tests might start to use them directly. I'm not sure what for, but they might.
> But if it is configurable tests probably should instead call a getter() for
> the currently set delay/step.
>
> Then all the methods that now mention DEFAULT_ would probably need to mention
> something like
> getMouseDelay() and getStepLength() instead.
>
> So it may be better to do it now ? Thoughts ?
@alisenchung did you see the above ?
Looks like email for it may not have been generated because I *edited* an old
comment rather than adding a new one.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22044#discussion_r2201751507
