On Fri, 11 Jul 2025 20:10:07 GMT, Phil Race <p...@openjdk.org> wrote:
>> "glide has over-rides step length" >> >> Sorry, that text was not clear. What I mean is that glide(..) accepts delay >> and step parameters, and so at least in that case you can over-ride with >> your preferred values. >> >> Other than that, it isn't configurable in the ExtendedRobot, so the need >> isn't clear. >> >> Even so, we could do this but whether now or later, but in either case, >> we ought to think now as to what it would look like so it can be compatibly >> added. >> >> In ExtendedRobot the equivalent fields are private but here they are public. >> Tests might start to use them directly. I'm not sure what for, but they >> might. >> But if it is configurable tests probably should instead call a getter() for >> the currently set delay/step. >> >> Then all the methods that now mention DEFAULT_ would probably need to >> mention something like >> getMouseDelay() and getStepLength() instead. >> >> So it may be better to do it now ? Thoughts ? > > @alisenchung did you see the above ? > Looks like email for it may not have been generated because I *edited* an old > comment rather than adding a new one. I think setting the default step length with a setter/getter makes sense. I think generally tests don't change the step delays across their glides anyway and it would remove the need for all those extra overrides for glide. I'll make this change now ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22044#discussion_r2205359550
