On Tue, 29 Jul 2025 12:44:24 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org> wrote:
>> When trying to call 'icon.setImage(null);' where 'icon' is an instance of >> ImageIcon, a null pointer exception is thrown at runtime. >> The code tried to get the `id` for that image and instantiates >> `MediaTracker` to associate the null image to that `id` and checks the >> status of loading this null image, removes the null image from the tracker >> and then tries to get the image width where it throws NPE as image is null. >> >> It's better to not go through all MediaTracker usage and bail out initially >> itself for null image.. > > Prasanta Sadhukhan has updated the pull request incrementally with one > additional commit since the last revision: > > Rectify @throws clause, update test to delete file test/jdk/javax/swing/ImageIcon/ImageIconTest.java line 54: > 52: File file = new File(imgName); > 53: file.deleteOnExit(); > 54: String fileName = file.getName(); Don't `imgName` and `fileName` store the same value now? ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25767#discussion_r2239786008
