On Tue, 29 Jul 2025 18:55:47 GMT, Phil Race <p...@openjdk.org> wrote:
>> Prasanta Sadhukhan has updated the pull request incrementally with three >> additional commits since the last revision: >> >> - Modify summary >> - Modify summary >> - Remove redundant fileName param > > src/java.desktop/share/classes/javax/swing/ImageIcon.java line 68: > >> 66: * If the image source parameter to a constructor or method is non-null, >> 67: * but does not reference valid accessible image data, >> 68: * no exceptions will be thrown but the image will be unset, > > "will behave as if unset" ? > or maybe > "will behave as if uninitialized " ? @prrace Any objection to my suggestion of statement? I guess that is succinct and describe what's the end result!! `no exceptions will be thrown but the image will behave as if unset/uninitialized/null` doesn't sound right in my opinion as then user need to know "how it would behave" when image is unset or null which is basically image icon not getting rendered so I thought to cut the chase and describe the final result ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25767#discussion_r2244215823
