On Fri, 1 Aug 2025 05:19:46 GMT, Prasanta Sadhukhan <psadhuk...@openjdk.org>
wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8364230
>
> src/java.desktop/share/classes/javax/swing/text/StringContent.java line 29:
>
>> 27: import java.util.Vector;
>> 28: import java.io.Serializable;
>> 29: import javax.swing.undo.*;
>
> wildcard
I am not doing clean up
> test/jdk/javax/swing/text/AbstractDocument/StringContentPositionTest.java
> line 65:
>
>> 63: for (int i=0; i<SIZE; i++) {
>> 64: if (positions[i].getOffset() != 0) {
>> 65: System.err.println("remove: Bad offset i=" + i + " off="
>> + positions[i].getOffset());
>
> Why a RuntimeException is not thrown instead of just logging?
Because I was testing and wanted to see all errors - I've fixed this now
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26519#discussion_r2252569854
PR Review Comment: https://git.openjdk.org/jdk/pull/26519#discussion_r2252581327
