On Wed, 6 Aug 2025 05:43:10 GMT, Prasanta Sadhukhan <[email protected]>
wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8364230
>
> test/jdk/javax/swing/text/AbstractDocument/StringContentPositionTest.java
> line 33:
>
>> 31: */
>> 32:
>> 33: public class StringContentPositionTest {
>
> I believe @bug is not added because this is not strictly a regression test
> for this issue as I see it does not fail even without the fix?
> Since `System.gc` is used, can we try restricting the heap size in
> commandline to see if it will fail without the fix and pass with it?
It won't fail either way. I just changed how the clean up was done.
And GC is kicking in anyway with default settings.
So no point on both counts.
> test/jdk/javax/swing/text/AbstractDocument/StringContentPositionTest.java
> line 54:
>
>> 52: for (int i = 0; i < SIZE; i++) {
>> 53: SC.insertString(0, TEXT);
>> 54: positions[i] = SC.createPosition(5);
>
> should it be LEN instead of 5?
yes. fixed
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26519#discussion_r2258090594
PR Review Comment: https://git.openjdk.org/jdk/pull/26519#discussion_r2258091404
