On Tue, 19 Aug 2025 17:22:01 GMT, Manukumar V S <m...@openjdk.org> wrote:

>> Khalid Boulanouare has updated the pull request with a new target base due 
>> to a merge or a rebase. The incremental webrev excludes the unrelated 
>> changes brought in by the merge/rebase. The pull request contains 39 
>> additional commits since the last revision:
>> 
>>  - Merge branch 'openjdk:master' into jdk-8158801
>>  - Centers missed frames in the middle of screen
>>  - Uses KeyboardFocusManager instead of FocusManager
>>  - Reverted not needed changes
>>  - Updates copyright years
>>  - Merge branch 'openjdk:master' into jdk-8158801
>>  - Centers frames in the middle of the screen
>>  - Releses latch in case of null ancestor or resizing component
>>  - Update 
>> test/jdk/java/awt/Mixing/AWT_Mixing/GlassPaneOverlappingTestBase.java
>>    
>>    Co-authored-by: Alexey Ivanov <alexey.iva...@oracle.com>
>>  - Update 
>> test/jdk/java/awt/Mixing/AWT_Mixing/GlassPaneOverlappingTestBase.java
>>    
>>    Co-authored-by: Alexey Ivanov <alexey.iva...@oracle.com>
>>  - ... and 29 more: https://git.openjdk.org/jdk/compare/30e3294f...9358a9d8
>
> test/jdk/java/awt/Mixing/AWT_Mixing/JComboBoxOverlapping.java line 67:
> 
>> 65:         frame.getContentPane().setLayout(new 
>> BoxLayout(frame.getContentPane(), BoxLayout.Y_AXIS));
>> 66:         frame.setSize(200, 200);
>> 67:         frame.setLocationRelativeTo(null);
> 
> Are we disposing this frame somewhere(it's applicable to all the test files)?

@manukumarvs in the original test, frames are not disposed. I will include 
disposing frame after testing the heavyweight component.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2293204208

Reply via email to