On Fri, 22 Aug 2025 16:41:14 GMT, Khalid Boulanouare <d...@openjdk.org> wrote:
>> Many Mixing tests failed because the work around click lands on the
>> minimizing area in the window control and causes the tests to fail.
>>
>> This fix changes the width of base frames which allows most of tests to pass.
>
> Khalid Boulanouare has updated the pull request incrementally with two
> additional commits since the last revision:
>
> - Disposes frames after each AWT component test
> - Removes redundant code for centring frames
Please share the CI job result in JBS and run the job atleast a few times just
to ensure these are passing on all iterations..
test/jdk/java/awt/Mixing/AWT_Mixing/GlassPaneOverlappingTestBase.java line 63:
> 61: {
> 62: multiFramesTest = false;
> 63: }
what is this for?
test/jdk/java/awt/Mixing/AWT_Mixing/SimpleOverlappingTestBase.java line 172:
> 170: if (!await) {
> 171: throw new RuntimeException("Ancestor frame didn't
> receive " +
> 172: "focus");
I guess this latch wait needs to be moved to `ancestor != null` block as it is
a noop for null ancestor
test/jdk/java/awt/Mixing/AWT_Mixing/SimpleOverlappingTestBase.java line 176:
> 174: clickAndBlink(robot, lLoc);
> 175: if(ancestor != null && multiFramesTest){
> 176: ancestor.dispose();
why to dispose only for multiFramesTest, even single frame needs to be
disposed!!
-------------
PR Review: https://git.openjdk.org/jdk/pull/25971#pullrequestreview-3167314519
PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2309101130
PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2309100322
PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2309102164
