On Fri, 22 Aug 2025 19:39:18 GMT, Phil Race <p...@openjdk.org> wrote:
> > > I already ran all our automated tests, and I'm not too surprised they > > > pass, since they probably don't cover this as well as they should. > > > > > > Thanks! > > > I think it would be possible and a good idea to add a test. All you need > > > to do is find a font that definitely supports Khmer. > > > > > > I can use > > [`hb-subset`](https://man.archlinux.org/man/extra/harfbuzz-utils/hb-subset.1.en) > > to create a subset of the [KhmerOS](https://www.cambodia.org/fonts/) open > > source font (licensed under LGPL 2.1 or later) which will be just enough > > for the test and check that in along with the test. The subsetted font file > > will be 28kb. Would that be acceptable > > No. That won't be allowed. You aren't using your own IP. Sorry, but I don't understand the problem? We have a bunch of other third-party libraries which are included in OpenJDK along with their corresponding license files. Just do a `find . -name legal -type d -exec echo {} ; -exec ls -la {} ;` in the top level directory to find them all. We even have the whole [DejaVu font family](https://github.com/openjdk/jdk/blob/master/src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resources/fonts/dejavu.css) in the source tree with its license in [src/jdk.javadoc/share/legal/dejavufonts.md](https://github.com/openjdk/jdk/blob/master/src/jdk.javadoc/share/legal/dejavufonts.md) (added by [JDK-8324774: Add DejaVu web fonts](https://bugs.openjdk.org/browse/JDK-8324774)). I don't see why we wouldn't be able to do something similar for a test font as long as it is available under a permissive open source license like the [GNU Lesser General Public License](https://www.gnu.org/licenses/old-licenses/lgpl-2.1.html)? ------------- PR Comment: https://git.openjdk.org/jdk/pull/26825#issuecomment-3219251877
