On Fri, 29 Aug 2025 16:15:43 GMT, Phil Race <p...@openjdk.org> wrote:
>> src/java.desktop/share/native/common/java2d/opengl/OGLBlitLoops.c line 412:
>>
>>> 410: // in case pixel stride is not a multiple of scanline stride the
>>> copy
>>> 411: // has to be done line by line (see 6207877)
>>> 412: if (pf != NULL) {
>>
>> https://github.com/openjdk/jdk/blob/c96d09acd95d0ccf2fef50b8ccfeb5e2a0aa0968/src/java.desktop/share/native/common/java2d/opengl/OGLBlitLoops.c#L651
>>
>> OGLBlitSwToTexture is called with PixelFormat defined as
>>
>> https://github.com/openjdk/jdk/blob/c96d09acd95d0ccf2fef50b8ccfeb5e2a0aa0968/src/java.desktop/share/native/common/java2d/opengl/OGLSurfaceData.c#L52-L76
>>
>> which is not null so not sure why pf will ever be null? Did you see it null
>> anytime?
>
> This was discussed already. There's another call site that passes NULL.
Oh this is a different function. Not the one previously discussed, looks like
it was added to the PR later.
This case at least *currently* cannot be called with NULL for the reason above.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26799#discussion_r2310597094
