On Mon, 1 Sep 2025 10:24:58 GMT, Artem Semenov <[email protected]> wrote:
>> The defect has been detected and confirmed in the function >> OGLBlitToSurfaceViaTexture() located in the file >> src/java.desktop/share/native/common/java2d/opengl/OGLBlitLoops.c with >> static code analysis. This defect can potentially lead to a null pointer >> dereference. >> >> The pointer pf is dereferenced in line 324 without checking for nullptr, >> although earlier in line 274 the same pointer is checked for nullptr, which >> indicates that it can be null. >> >> In the same file, line 551 calls OGLBlitToSurfaceViaTexture() from line 263, >> where NULL is passed in place of pf. >> All other calls are fine. >> >> Also, another function with a similar issue from the same file, >> OGLBlitSwToTexture() from line 396. >> >> In src/java.desktop/unix/native/libawt_xawt/awt/gtk3_interface.c gtk3_load() >> The pointer fp_glib_check_version can be null, but it is dereferenced >> without any check. Although in the same file, for example, line 280 contains >> a check, this check does not lead to termination of execution. >> >> >> In src/java.desktop/share/native/libsplashscreen/splashscreen_gif.c >> SplashDecodeGif() >> The pointer colorMap is dereferenced after it has been checked against >> nullptr in lines 151 and 206. Moreover, between these checks and the >> mentioned location (line 282), the pointer is not modified in any way. >> >> According to >> [this](https://github.com/openjdk/jdk/pull/26002#issuecomment-3023050372) >> comment, this PR contains fixes for similar cases in other places. > > Artem Semenov has updated the pull request incrementally with three > additional commits since the last revision: > > - Revert "The same issue is present in > src/java.desktop/share/native/common/java2d/opengl/OGLBlitLoops.c > OGLBlitSwToTexture()" > > This reverts commit c4b87121234bb1427f5e611adf5726ac5b3d15e3. > - Revert "8365609 Null pointer dereference in > src/java.desktop/share/native/common/java2d/opengl/OGLBlitLoops.c > OGLBlitToSurfaceViaTexture()" > > This reverts commit ff9825cd7d8838c90daa804e794576282be7bb81. > - Revert "Fixed indentation" > > This reverts commit c96d09acd95d0ccf2fef50b8ccfeb5e2a0aa0968. Marked as reviewed by serb (Reviewer). ------------- PR Review: https://git.openjdk.org/jdk/pull/26799#pullrequestreview-3342665165
