On Mon, 25 Aug 2025 13:35:43 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:
>> ScientificWare has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 25 commits: >> >> - Merge master >> - JDK-8314731 : Remove all indentations accidentally introduced by the >> previous commit. >> - Merge master >> - Merge master >> - jdk-8314731 : FormView Alt Support. >> >> FormView.java : >> - revert ALL unrelated changing to formatting. >> >> bug8314731.java : >> - Fix the test description. >> - Change where the user interface is created. >> - Add a finall block to be sure the Frame is disposed. >> - Replace "testPassed" with "testFailed". >> - Merge master >> - Replaces this title with "alt attribute test in HTML image type input". >> >> Moves this test to /jdk/test/jdk/javax/swing/text/html. >> - bug8314731.java : Corrects the CopyRight date. >> - FormView.java : >> Removes a whitespace >> >> bug8314731.java : >> Adds a newline at end of file. >> - getMaximumSpan(int axis) method >> doc -> Not used >> >> mouseReleased(MouseEvent evt) method >> elem and hdoc -> not used >> return -> could be removed, method returns void >> >> loadElementDataIntoBuffer(Element elem, StringBuilder buffer) method >> value != null -> name can't be null at this point >> >> getInputElementData(AttributeSet attr) method >> value = null -> Already set at null >> - ... and 15 more: https://git.openjdk.org/jdk/compare/69e664de...9b423808 > > test/jdk/javax/swing/text/html/bug8314731.java line 28: > >> 26: * @bug 8314731 >> 27: * @summary FormView doesn't support the alt attribute >> 28: * @key headful > > Suggestion: > > * @bug 8314731 > * @key headful > * @summary FormView doesn't support the alt attribute > > Usually, `@key` follows after `@bug`… for consistency with other tests. Addressed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/15319#discussion_r2328648442
