On Tue, 23 Sep 2025 05:38:09 GMT, Damon Nguyen <[email protected]> wrote:

>>> it does not seem like Aqua L&F even touches `menuKeyPressed()` in 
>>> `BasicPopupMenuUI.java`. Or at least, not that portion.
>> 
>> Hello @DamonGuy ,
>> I used the same macOS version with the same Look & Feel, and it works fine 
>> on my end.
>> Just to clarify,  do you mean you can’t even see the 'a' key pressed, or are 
>> you referring specifically to the mnemonics for 'i' and 'f'?
>> Thanks
>
>> > it does not seem like Aqua L&F even touches `menuKeyPressed()` in 
>> > `BasicPopupMenuUI.java`. Or at least, not that portion.
>> 
>> Hello @DamonGuy , I used the same macOS version with the same Look & Feel, 
>> and it works fine on my end. Just to clarify, do you mean you can’t even see 
>> the 'a' key pressed, or are you referring specifically to the mnemonics for 
>> 'i' and 'f'? Thanks
> 
> I mean I tried debugging the change and checking if the `else if` block that 
> you added `consumeNextKeyTyped` to was even reached by the time the test 
> failed. It seems to not if I were to put a print statement in there for an 
> example. Does it print for you if you add one there or anywhere else in the 
> `menuKeyPressed` API?
> 
> I triple-checked that I have the correct changes from this PR. With the 
> changes, the test still fails with:
> 
> ----------System.out:(1/50)----------
> Test: character typed after mnemonic key press: i
> ----------System.err:(13/744)----------
> Test: character typed with VK_A: a
> java.lang.RuntimeException: Test failed!

@DamonGuy

> I have rebuilt the changes on my other macOS device. It seems to work. I'm 
> inclined to say this passes now and that it was a host issue on my side for 
> my other device.

Interesting, wondering if macOS version has an effect. Which version are you 
testing it on?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/26790#issuecomment-3324903123

Reply via email to