On Sun, 5 Oct 2025 20:33:26 GMT, Phil Race <[email protected]> wrote: > Specifying the behaviour of BufferedImage constructors for invalid dimensions > is long overdue. > > The behaviour for image types and sizes <= 0 is unchanged by this PR. > Also in many cases the behaviour for sizes that are too large is also > unchanged. > In some cases, the behaviour is changed from "accidental" > NegativeArraySizeException to a consistent IllegalArgumentException. > > In no case is anything changed that would affect the possibility to construct > a BufferedImage. > > A test is provided to ensure the behaviour. > > A CSR is provided too : https://bugs.openjdk.org/browse/JDK-8369155
The additional checks for throwing exceptions look logical and fine to me. As mentioned, there isn't any behavioral changes to the constructor, and I found no issues with this when testing. ------------- Marked as reviewed by dnguyen (Committer). PR Review: https://git.openjdk.org/jdk/pull/27640#pullrequestreview-3502501936
