On Wed, 26 Nov 2025 16:22:40 GMT, Alexey Ivanov <[email protected]> wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 4617681
>
> src/java.desktop/share/classes/java/awt/image/BufferedImage.java line 292:
>
>> 290: * image types. The {@code ColorSpace} for the image is the
>> 291: * default sRGB space.
>> 292: * {@code BufferedImage} is a type that supports only one tile.
>
> Suggestion:
>
> * default sRGB space.
> * <p>
> * {@code BufferedImage} is a type that supports only one tile.
>
> To start a new paragraph? I think it would improve readability.
I did this but not on the line you suggested.
> src/java.desktop/share/classes/java/awt/image/BufferedImage.java line 297:
>
>> 295: * Java primitive arrays so the number of samples that can be
>> 296: * stored are limited by the maximum size of a Java array.
>> 297: * This is at most {@code Integer.MAX_VALUE}.
>
> Shouldn't the sentence "This is at most…", be linked to the previous sentence
> with a comma. *This* refers to *the maximum size of a Java array*, it could
> be not as clear when these closely related sentences are split into two
> separate sentences.
I think this is OK as it is.
> src/java.desktop/share/classes/java/awt/image/BufferedImage.java line 299:
>
>> 297: * This is at most {@code Integer.MAX_VALUE}.
>> 298: * The number of samples per-pixel for an {@code imageType} affect
>> 299: * the maximum. For example if an image format uses bytes to store
>
> Suggestion:
>
> * the maximum. For example, if an image format uses bytes to store
>
>
> A comma after “for example”.
done
> src/java.desktop/share/classes/java/awt/image/BufferedImage.java line 303:
>
>> 301: * it will only be able to hold one fourth as many pixels as an
>> image
>> 302: * that uses an int to store all four samples.
>> 303: * For example {@code TYPE_4BYTE_ABGR} may use 4 bytes to store a
>> pixel
>
> Suggestion:
>
> * For example, {@code TYPE_4BYTE_ABGR} may use 4 bytes to store a pixel
done
> src/java.desktop/share/classes/java/awt/image/BufferedImage.java line 307:
>
>> 305: * So the maximum number of pixels in a {@code BufferedImage} is
>> 306: * format dependent.
>> 307: * @param width width of the created image
>
> Suggestion:
>
> * format dependent.
> *
> * @param width width of the created image
>
> I'd add a blank line here to visually separate the description from the
> parameter list.
done
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27640#discussion_r2586890082
PR Review Comment: https://git.openjdk.org/jdk/pull/27640#discussion_r2586890550
PR Review Comment: https://git.openjdk.org/jdk/pull/27640#discussion_r2586890854
PR Review Comment: https://git.openjdk.org/jdk/pull/27640#discussion_r2586891063
PR Review Comment: https://git.openjdk.org/jdk/pull/27640#discussion_r2586891538
