On Wed, 26 Nov 2025 16:19:52 GMT, Christian Heilmann <[email protected]> wrote:
>> This PR fixes a bug that caused no or the wrong set of pages to be printed >> when using page ranges on macOS. >> >> The main fix is to change the 'location' value of the returned NSRange from >> the knowsPageRange method to 1 in the native class PrinterView.m. > > Christian Heilmann has updated the pull request with a new target base due to > a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains nine additional > commits since the last revision: > > - Merge branch 'openjdk:master' into pr/8297191 > - Update PrinterView.m > - Update PrinterView.h > - Update CPrinterJob.m > - 8297191 fixed printing page range for e.g. page 2 to 2 on macOS > - 8297191 fixed printing page range for e.g. page 2 to 2 on macOS > - Merge branch 'master' of https://github.com/openjdk/jdk into pr/11266 > - Merge branch 'master' into pr/11266 > - 8297191 fixed printing page range for e.g. page 2 to 2 on macOS > > Meaning, even if running on macOS 26 they'll fail ? I suppose that's > > possible, or even likely, but it would be good to verify that. > > Yes.\ > I agree we should confirm it's the case. @prrace I tested on a macOS 26, both `DlgAttrsBug.java` and `PageRangesDlgTest.java` fail if I uncomment the lines; the tests pass if I use a recent mainline build or a build from this PR. So, testing results rule out this second option for fixing this bug. ------------- PR Comment: https://git.openjdk.org/jdk/pull/11266#issuecomment-3582116510
