On Wed, 26 Nov 2025 16:19:52 GMT, Christian Heilmann <[email protected]> wrote:
>> This PR fixes a bug that caused no or the wrong set of pages to be printed >> when using page ranges on macOS. >> >> The main fix is to change the 'location' value of the returned NSRange from >> the knowsPageRange method to 1 in the native class PrinterView.m. > > Christian Heilmann has updated the pull request with a new target base due to > a merge or a rebase. The incremental webrev excludes the unrelated changes > brought in by the merge/rebase. The pull request contains nine additional > commits since the last revision: > > - Merge branch 'openjdk:master' into pr/8297191 > - Update PrinterView.m > - Update PrinterView.h > - Update CPrinterJob.m > - 8297191 fixed printing page range for e.g. page 2 to 2 on macOS > - 8297191 fixed printing page range for e.g. page 2 to 2 on macOS > - Merge branch 'master' of https://github.com/openjdk/jdk into pr/11266 > - Merge branch 'master' into pr/11266 > - 8297191 fixed printing page range for e.g. page 2 to 2 on macOS > While this PR was on review, the > `test/jdk/java/awt/print/PrinterJob/PageRanges.java` test was updated to the > `PassFailJFrame` framework. The test can now be run with jtreg and, > therefore, it can be used to verify the fix. > > Thus, _add 8297191 to the `@bug` tag in `PrinterJob/PageRanges.java`_. > > (You will need to merge master into your branch.) > > [I had already asked for > it](https://github.com/openjdk/jdk/pull/11266#pullrequestreview-3152815416). I merged the master into this branch and added 8297191 to @bug in PageRanges.java. ------------- PR Comment: https://git.openjdk.org/jdk/pull/11266#issuecomment-3582117036
