On Thu, 11 Dec 2025 18:32:06 GMT, Alexey Ivanov <[email protected]> wrote:
>> Khalid Boulanouare has updated the pull request with a new target base due >> to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains 66 >> additional commits since the last revision: >> >> - Merge branch 'openjdk:master' into jdk-8158801 >> - Merge branch 'openjdk:master' into jdk-8158801 >> - Removes uncessary import and adds blank lines between import blocks >> - Makes inherited method final >> - Removes unnecessary URL >> - Fixes a typo >> - Removes unncessary boolean variable, line and import >> - Merge branch 'openjdk:master' into jdk-8158801 >> - Cleans up code for move visibility >> - Cleans up code and adds missed import >> - ... and 56 more: https://git.openjdk.org/jdk/compare/98b872f3...59a937ac > > test/jdk/java/awt/Mixing/AWT_Mixing/JPopupMenuOverlapping.java line 69: > >> 67: frame.setVisible(false); >> 68: } >> 69: frame = new JFrame("Mixing : Dropdown Overlapping test"); > > Should the old frame be disposed of instead of just hidden? > > Is it even possible that `frame` is not `null`? This is a question for further refactoring… No need to address it now. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/25971#discussion_r2611694210
