On Mon, 19 Jan 2026 08:56:32 GMT, Prasanta Sadhukhan <[email protected]>
wrote:
>> src/java.desktop/windows/classes/com/sun/java/swing/plaf/windows/WindowsIconFactory.java
>> line 938:
>>
>>> 936: (icon.getIconHeight()
>>> <= 16) ? y + OFFSET : (y + icon.getIconHeight() / 2), state);
>>> 937: } else {
>>> 938: skin.paintSkin(g,
>>
>> Can we optimize the code here, since mostly `x` is changing here based on
>> conditions. It'll help in readability and review too.
>
> No, y is also changing depending on icon height...
> As of now, any more optimization is not possible, it can be done as followup
> if it is needed..
Line 926, 930, 936 and 940 looks same to me. I'm referring to these lines.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28889#discussion_r2704292249
