On Thu, 18 Dec 2025 07:34:36 GMT, Prasanta Sadhukhan <[email protected]> wrote:
> Check/radiobutton icon are not aligned properly in RTL. `WindowsMenuItemUI > `uses `MenuItemLayoutHelper.layoutMenuItem` to do the layout which calls > `doRTLColumnLayout `which calculates x positions in `calcXPositionsRTL `and > then again aligns in `alignRects`. However, since in Windows historically > radiobutton/check icon was not drawn or drawn below the menuitem image icon > (since image icon and check icon was drawn in the same layout space and not > separately) the aligned x position of check icons returned from > `MenuItemLayoutHelper` was not correct but since `MenuItemLayoutHelper` > alignment is used in other L&Fs also so we need to realign it in windows > specific class i.e in WindowsIconFactory in paintIcon > > Before fix > > <img width="425" height="646" alt="image" > src="https://github.com/user-attachments/assets/6aac649d-b099-4e11-ba9a-83c623034287"; > /> > > After fix > > <img width="430" height="641" alt="image" > src="https://github.com/user-attachments/assets/e0ea7e3e-d6cb-44a6-aa4f-78435f85d6fb"; > /> This pull request has now been integrated. Changeset: e45f5656 Author: Prasanta Sadhukhan <[email protected]> URL: https://git.openjdk.org/jdk/commit/e45f5656bc90421c9acb0cbf87164162039ddf81 Stats: 40 lines in 1 file changed: 36 ins; 0 del; 4 mod 8373650: Test "javax/swing/JMenuItem/6458123/ManualBug6458123.java" fails because the check icons are not aligned properly as expected Reviewed-by: tr, dnguyen ------------- PR: https://git.openjdk.org/jdk/pull/28889
