Re: RFR: 8376423: Test javax/swing/plaf/metal/MetalUtils/bug6190373.java failed: ClassCastException: class java.lang.Character cannot be cast to class javax.swing.Painter

[Alexey Ivanov]

On Tue, 27 Jan 2026 04:23:33 GMT, Phil Race <p...@openjdk.org> wrote:

> AppContext is removed from Swing LAF state. Tests which require it are 
> deleted.

Changes requested by aivanov (Reviewer).

src/java.desktop/share/classes/javax/swing/UIManager.java line 247:

> 245:      */
> 246:     private static LAFState getLAFState() {
> 247:         return LAF_STATE;

I think you still have to use `synchronized (classLock)`, otherwise 
`LAF_STATE.initialized` in `isLafStateInitialized` could return a stale value.

src/java.desktop/share/classes/sun/swing/SwingAccessor.java line 136:

> 134:     }
> 135: 
> 136:     /*

Suggestion:

    /**

Should it be javadoc-style comment?

src/java.desktop/share/classes/sun/swing/SwingAccessor.java line 137:

> 135: 
> 136:     /*
> 137:      * An accessor for the LAFState class state

Suggestion:

     * An accessor for the LAFState class state.

Full stop?

src/java.desktop/share/classes/sun/swing/SwingAccessor.java line 152:

> 150: 
> 151:     /**
> 152:      * Retrieve the accessor object for the LAFState class

Suggestion:

     * Retrieve the accessor object for the LAFState class.

Full stop?

-------------

PR Review: https://git.openjdk.org/jdk/pull/29437#pullrequestreview-3712170748
PR Review Comment: https://git.openjdk.org/jdk/pull/29437#discussion_r2732859461
PR Review Comment: https://git.openjdk.org/jdk/pull/29437#discussion_r2732823443
PR Review Comment: https://git.openjdk.org/jdk/pull/29437#discussion_r2732824817
PR Review Comment: https://git.openjdk.org/jdk/pull/29437#discussion_r2732826199