Re: RFR: 8376423: Test javax/swing/plaf/metal/MetalUtils/bug6190373.java failed: ClassCastException: class java.lang.Character cannot be cast to class javax.swing.Painter [v2]

[Phil Race]

On Tue, 27 Jan 2026 16:22:39 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:

>> Phil Race has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   8376423
>
> src/java.desktop/share/classes/sun/swing/SwingAccessor.java line 136:
> 
>> 134:     }
>> 135: 
>> 136:     /*
> 
> Suggestion:
> 
>     /**
> 
> Should it be javadoc-style comment?

I don't think it matters and there's inconsistency in the other interfaces, but 
I can add a "*"

> src/java.desktop/share/classes/sun/swing/SwingAccessor.java line 137:
> 
>> 135: 
>> 136:     /*
>> 137:      * An accessor for the LAFState class state
> 
> Suggestion:
> 
>      * An accessor for the LAFState class state.
> 
> Full stop?

also inconsistent.

> src/java.desktop/share/classes/sun/swing/SwingAccessor.java line 152:
> 
>> 150: 
>> 151:     /**
>> 152:      * Retrieve the accessor object for the LAFState class
> 
> Suggestion:
> 
>      * Retrieve the accessor object for the LAFState class.
> 
> Full stop?

ok

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29437#discussion_r2733251777
PR Review Comment: https://git.openjdk.org/jdk/pull/29437#discussion_r2733255153
PR Review Comment: https://git.openjdk.org/jdk/pull/29437#discussion_r2733259871