On Wed, 25 Mar 2026 03:38:39 GMT, David Holmes <[email protected]> wrote:
>> Matthias Baesken has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Move JVM_dladdr to jvm_md.h > > src/hotspot/os/posix/include/jvm_md.h line 67: > >> 65: #if defined(AIX) >> 66: #include "jni_md.h" >> 67: #include "dl_info.h" > > Can't we do a simple forward declaration for struct Dl_info and get rid of > this header file? @MBaesken how is this "resolved"? > src/hotspot/os/posix/include/jvm_md.h line 71: > >> 69: #ifdef __cplusplus >> 70: extern "C" >> 71: #endif > > This should be paired with a trailing: > > #ifdef __cplusplus > } /* extern "C" */ > #endif /* __cplusplus */ You could have pointed out to me that I had missed that the original line did not have the opening brace and so no closing brace was needed. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/30295#discussion_r2992057122 PR Review Comment: https://git.openjdk.org/jdk/pull/30295#discussion_r2992063022
