On Thu, 26 Mar 2026 02:11:17 GMT, David Holmes <[email protected]> wrote:

>> src/hotspot/os/posix/include/jvm_md.h line 71:
>> 
>>> 69: #ifdef __cplusplus
>>> 70: extern "C"
>>> 71: #endif
>> 
>> This should be paired with a trailing:
>> 
>> #ifdef __cplusplus
>> } /* extern "C" */
>> #endif /* __cplusplus */
>
> You could have pointed out to me that I had missed that the original line did 
> not have the opening brace and so no closing brace was needed.

Okay yes but I thought you just liked the version with braces better (and 
across the coding it seems we use the one with braces more so let's do it here 
too) .

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/30295#discussion_r2993347188

Reply via email to