On Tue, 7 Apr 2026 17:58:19 GMT, Alexey Ivanov <[email protected]> wrote:

> Add `@build jdk.test.lib.Asserts` to ensure the `Asserts` class from the 
> library (`/lib`) is compiled for all the tests in 
> `test/jdk/java/awt/Modal/FileDialog/`. The tests use `Asserts` indirectly, 
> via the helper classes in the `helpers` folder: `TestDialog`, `TestFrame`, 
> `TestWindow`.
> 
> In all these classes, `ExtendedRobot` which is used in helpers is explicitly 
> referenced, but `Asserts` isn't.
> 
> Adding this `@build` tag ensures the class is compiled/updated for each test, 
> otherwise, there could be intermittent failures due to missing classes.
> 
> Additionally, I expanded imports in the helper classes for this test suite.

Marked as reviewed by serb (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/30610#pullrequestreview-4071252827

Reply via email to