On Tue, 7 Apr 2026 17:58:19 GMT, Alexey Ivanov <[email protected]> wrote:

> Add `@build jdk.test.lib.Asserts` to ensure the `Asserts` class from the 
> library (`/lib`) is compiled for all the tests in 
> `test/jdk/java/awt/Modal/FileDialog/`. The tests use `Asserts` indirectly, 
> via the helper classes in the `helpers` folder: `TestDialog`, `TestFrame`, 
> `TestWindow`.
> 
> In all these classes, `ExtendedRobot` which is used in helpers is explicitly 
> referenced, but `Asserts` isn't.
> 
> Adding this `@build` tag ensures the class is compiled/updated for each test, 
> otherwise, there could be intermittent failures due to missing classes.
> 
> Additionally, I expanded imports in the helper classes for this test suite.

This pull request has now been integrated.

Changeset: cfae18fa
Author:    Alexey Ivanov <[email protected]>
URL:       
https://git.openjdk.org/jdk/commit/cfae18fa606d8924f1f020b0f2de8617dd648bb2
Stats:     135 lines in 39 files changed: 79 ins; 0 del; 56 mod

8381745: Ensure Modal/FileDialog tests explicitly reference Asserts class

Reviewed-by: serb, dmarkov

-------------

PR: https://git.openjdk.org/jdk/pull/30610

Reply via email to