On Thu, 7 May 2026 04:20:35 GMT, Sergey Bylokhov <[email protected]> wrote:
>> This PR fixes a failure of bug4133768.java on macOS aarch64 by adding an RGB >> tolerance of 5. >> >> Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64: >> >> make test TEST=test/jdk/javax/swing/AbstractButton/bug4133768.java >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Tolerance is only used if the final rendering cannot be controlled by java, > like shadows/transparency/etc the things which are controlled by the OS. Can > you check that sRGB profile is set on the test system? > > Some notes about how the systems should be configured: > https://wiki.openjdk.org/spaces/ClientLibs/pages/81952779/Automated+client+GUI+testing+system+set+up+requirements @mrserb The test's goal is to distinguish between disabled and enabled button states. The tolerance accounts for OS specific color rendering differences. As shown in the color samples below, the tolerance remains well within the range needed to reliably differentiate between the two button states. <img width="193" height="455" alt="Screenshot 2026-05-07 at 6 16 34 AM" src="https://github.com/user-attachments/assets/163b8ecb-ae03-4c68-be69-cdc002c2c473"; /> <img width="186" height="462" alt="Screenshot 2026-05-07 at 6 16 02 AM" src="https://github.com/user-attachments/assets/c909c658-5d17-4dda-a9c4-59e2175e09cb"; /> <img width="184" height="466" alt="Screenshot 2026-05-07 at 6 09 08 AM" src="https://github.com/user-attachments/assets/844f458b-0e1f-4c2d-a3fe-b80be5a5caa4"; /> ------------- PR Comment: https://git.openjdk.org/jdk/pull/31061#issuecomment-4397473370
