On Wed, 6 May 2026 17:34:41 GMT, Roland Mesde <[email protected]> wrote:
> This PR fixes a failure of bug4133768.java on macOS aarch64 by adding an RGB > tolerance of 5. > > Ran related tests on linux-x64, linux-aarch64, macos-aarch64 and windows-x64: > > make test TEST=test/jdk/javax/swing/AbstractButton/bug4133768.java > > Results: > > [windows-x64-specific-test.log](https://github.com/user-attachments/files/27487190/windows-x64-specific-test.log) > [macos-aarch64-specific-test.log](https://github.com/user-attachments/files/27487191/macos-aarch64-specific-test.log) > [linux-x64-specific-test.log](https://github.com/user-attachments/files/27487192/linux-x64-specific-test.log) > [linux-aarch64-specific-test.log](https://github.com/user-attachments/files/27487193/linux-aarch64-specific-test.log) > > --------- > - [x] I confirm that I make this contribution in accordance with the [OpenJDK > Interim AI Policy](https://openjdk.org/legal/ai). Any result not obtained with sRGB should be completely disregarded. This doesn't sound like a shadow/edge effect. If you are sampling near the centre of this large button, you should get the pure correct colour. One thing we've found we need to be careful of is that sometimes the mouse pointer is captured, and so we try to avoid capturing near that location. But then the colour will be completely wrong, not just off by a bit. In summary, what I'm hearing is that this change isn't needed or appropriate. ------------- PR Comment: https://git.openjdk.org/jdk/pull/31061#issuecomment-4400302029
