Re: RFR: 8248122: java launcher should launch normally if JavaFX modules not found [v3]

[Christopher Schnick]

On Wed, 13 May 2026 16:29:18 GMT, Alexey Ivanov <aiva...@openjdk.org> wrote:

>> Christopher Schnick has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   Revert comment
>
> src/java.base/share/classes/sun/launcher/LauncherHelper.java line 775:
> 
>> 773:         if 
>> ((JAVAFX_FXHELPER_CLASS_NAME_SUFFIX.equals(mainClass.getName()) ||
>> 774:                 doesExtendFXApplication(mainClass)) &&
>> 775:                 
>> ModuleLayer.boot().findModule(JAVAFX_GRAPHICS_MODULE_NAME).isPresent()) {
> 
> Suggestion:
> 
>         if ((JAVAFX_FXHELPER_CLASS_NAME_SUFFIX.equals(mainClass.getName()) ||
>                 (doesExtendFXApplication(mainClass)) &&
>                 
> ModuleLayer.boot().findModule(JAVAFX_GRAPHICS_MODULE_NAME).isPresent())) {
> 
> Parentheses will make associativity of the conditions clearer.

That is not equivalent, the expression already uses parentheses and does not 
rely on the operator order

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31016#discussion_r3236178758