Re: RFR: 8248122: java launcher should launch normally if JavaFX modules not found [v3]

[Alexey Ivanov]

On Wed, 13 May 2026 17:16:57 GMT, Christopher Schnick <crschn...@openjdk.org> 
wrote:

>> src/java.base/share/classes/sun/launcher/LauncherHelper.java line 775:
>> 
>>> 773:         if 
>>> ((JAVAFX_FXHELPER_CLASS_NAME_SUFFIX.equals(mainClass.getName()) ||
>>> 774:                 doesExtendFXApplication(mainClass)) &&
>>> 775:                 
>>> ModuleLayer.boot().findModule(JAVAFX_GRAPHICS_MODULE_NAME).isPresent()) {
>> 
>> Suggestion:
>> 
>>         if ((JAVAFX_FXHELPER_CLASS_NAME_SUFFIX.equals(mainClass.getName()) ||
>>                 (doesExtendFXApplication(mainClass)) &&
>>                 
>> ModuleLayer.boot().findModule(JAVAFX_GRAPHICS_MODULE_NAME).isPresent())) {
>> 
>> Parentheses will make associativity of the conditions clearer.
>
> That is not equivalent, the expression already uses parentheses and does not 
> rely on the operator order

Yes, you're right.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/31016#discussion_r3236299719