On Fri, 22 May 2026 03:40:22 GMT, Sergey Bylokhov <[email protected]> wrote:
>> Phil Race has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> 8381007
>
> src/java.desktop/share/classes/java/awt/image/MultiPixelPackedSampleModel.java
> line 115:
>
>> 113: DataBuffer.getDataTypeSize(dataType));
>> 114: if (sls < 0) {
>> 115: throw new RasterFormatException("Pixels do not fit");
>
> `sls` can be negative here not because of overflow, but because w is
> negative, which per the new spec should throw the next exception:
>
> * @throws IllegalArgumentException if either {@code w} or {@code h}
> * is less than or equal to 0
Seems the negative w is not covered by the test, so this one was missed?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/30826#discussion_r3285682357
